FIX: brain save_movie #9426
Merged
FIX: brain save_movie #9426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
May 25, 2021
larsoner
reviewed
May 25, 2021
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
One thing that did occur to me when reading the related issue is that in the brain test where we save a movie, we should load it using imageio-ffmpeg or something similar that can give the duration of the movie, and we can assert_allclose it to the expected duration given the time range and time dilation. This could be done for both the widget interface and the toolbar one. WDYT?
Contributor
Author
Sure, I'll add a test for it in this PR 👍 |
Contributor
Author
|
The test of https://github.com/mne-tools/mne-python/pull/9426/checks?check_run_id=2676293949#step:13:3143 |
Contributor
Author
|
The PR is ready to merge on my end @larsoner |
Member
|
Thanks @GuillaumeFavelier |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jun 2, 2021
* upstream/main: [MRG] change utils.logger.warning -> utils.warn (mne-tools#9434) FIX : rank computation from info now uses SSS proc history if only grad or mag are present (mne-tools#9435) MRG: Enable interpolation for all fNIRS types (mne-tools#9431) FIX: brain save_movie (mne-tools#9426) ENH: Add mne.export (mne-tools#9427) ENH: Test more on pre [skip circle] (mne-tools#9423) MRG, ENH: Speed up brain test (mne-tools#9422) MAINT: Update URL [ci skip] MNT: Reduce number of calls to _update (mne-tools#9407) MRG: Tutorial improvements (mne-tools#9416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes parameter forwarding in the
save_movie()method and also theSave movie...action in the tool bar.ToDo:
Closes #9425