-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG: Take mean of nirs channels that are too close for topoplot #7414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep this looks like about what I would expect to be required. Left some comments inline
|
Also I would recommend |
Codecov Report
@@ Coverage Diff @@
## master #7414 +/- ##
========================================
Coverage 90.03% 90.04%
========================================
Files 454 454
Lines 81400 82297 +897
Branches 13001 13020 +19
========================================
+ Hits 73288 74103 +815
- Misses 5267 5369 +102
+ Partials 2845 2825 -20 |
So it appears So I think I will tackle each topic in turn to keep things bite sized. I will look at |
Sounds reasonable to me. Another approach might be to make |
|
@agramfort and @larsoner could you please review. This is working nicely for me. |
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rob-luke !
| Data for channels with requested channels merged. Channels used in the | ||
| merge are removed from the array. | ||
| """ | ||
| to_remove = np.empty(0, dtype=np.int32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For linked lists the builtin list actually works quite well and probably faster than np.append, but it won't make any appreciable difference here
Reference issue
Alternative approach to #7410 as suggested by @larsoner
What does this implement/fix?
If nirs channels are too close for the topoplot to represent then those channels are combined by taking the mean.
Additional information
Initial attempt. No tests yet, just looking for feedback to see if I am on the right path. But this works on my data.