WIP: Expose ignore_overlap to evoked plot_topomap function #7410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
It is common in fNIRS to have source and detectors in a criss-cross pattern. I try and illustrate this below (excuse the poor ascii art)...
Here sources are indicated by
[s], and detectors by[d]. Channels are then formed between the sources and detectors indicated by a-, and byxwhere two sources and detectors have overlapping channels. For example there is a channel between s2 and d3, and one between s3 and d2 that overlap.This approach is used purposely to reduce noise (the overlapping channels should be measuring the same brain region), and for redundancy (its common to have a source or detector that fails or is blocked by hair/scars/etc).
Currently if you have this criss-cross pattern then the location of the channels is very close and MNE throws an error similar to...
The following electrodes have overlapping positions, which causes problems during visualization: S2_D3 hbo, S3_D2 hbo, ...In the future I would like to develop a way to combine overlapping channels in to a single optimal channel. But for now I would just like to be able to force MNE to allow me to view the data as a topomap. So I have exposed the ignore_overlap variable that was available in the lower level topomap function.
Additional information
I am keen to hear other approaches to how I can address this issue. I probably should have opened an issue and discussed the approach before I coded it.
None of the current nirs test data have overlapping channels. I will make sure the next set I upload does.