Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage check #59

Merged
merged 3 commits into from
May 2, 2023
Merged

Add coverage check #59

merged 3 commits into from
May 2, 2023

Conversation

RobbeSneyders
Copy link
Member

@RobbeSneyders RobbeSneyders commented May 2, 2023

Fixes #47

Coverage allows you to set a threshold for accepted coverage decline. Above it, the pipeline will fail. I currently set it at 0% since we should increase our coverage.

@RobbeSneyders RobbeSneyders force-pushed the feature/coverage branch 2 times, most recently from 3fdd568 to 490ec02 Compare May 2, 2023 09:43
@GeorgesLorre
Copy link
Collaborator

Cool! how does it track the coverage across PR's or is it a fixed number we set ?

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding

@RobbeSneyders
Copy link
Member Author

It compares with the main branch. You can see a full report on the coverage website:
https://coveralls.io/builds/59518590

@RobbeSneyders RobbeSneyders merged commit fbfb8ab into main May 2, 2023
@RobbeSneyders RobbeSneyders deleted the feature/coverage branch May 4, 2023 07:34
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
Fixes #47 

Coverage allows you to set a threshold for accepted coverage decline.
Above it, the pipeline will fail. I currently set it at 0% since we
should increase our coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coverage check
3 participants