Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage check #47

Closed
RobbeSneyders opened this issue Apr 25, 2023 · 0 comments · Fixed by #59
Closed

Add coverage check #47

RobbeSneyders opened this issue Apr 25, 2023 · 0 comments · Fixed by #59
Assignees
@RobbeSneyders
Labels
CI/CD Related to CI/CD of the repository
Milestone
0.1.0

Comments

@RobbeSneyders
Copy link
Member

We should add a coverage check of our test suite to Github actions. This provides a view of how well our test suite covers our code and can give indications on when / where to add tests. High coverage can help users trust the quality of Frondant.

We can look at Connexion for how to add this:
https://github.com/spec-first/connexion/blob/15fe2eda8fa1853a4d73a13839d7e35814ad7358/pyproject.toml#L76
https://github.com/spec-first/connexion/blob/15fe2eda8fa1853a4d73a13839d7e35814ad7358/tox.ini#L36
https://github.com/spec-first/connexion/blob/15fe2eda8fa1853a4d73a13839d7e35814ad7358/.github/workflows/pipeline.yml#L25
@RobbeSneyders RobbeSneyders added the CI/CD Related to CI/CD of the repository label Apr 25, 2023
@RobbeSneyders RobbeSneyders added this to the Alpha milestone Apr 25, 2023
@RobbeSneyders RobbeSneyders self-assigned this May 2, 2023
@RobbeSneyders RobbeSneyders mentioned this issue May 2, 2023
Merged
RobbeSneyders added a commit that referenced this issue May 2, 2023
@RobbeSneyders
Add coverage check (#59)
fbfb8ab 
Fixes #47 

Coverage allows you to set a threshold for accepted coverage decline.
Above it, the pipeline will fail. I currently set it at 0% since we
should increase our coverage.
Hakimovich99 pushed a commit that referenced this issue Oct 16, 2023
@RobbeSneyders
Add coverage check (#59)
1d18c81 
Fixes #47 

Coverage allows you to set a threshold for accepted coverage decline.
Above it, the pipeline will fail. I currently set it at 0% since we
should increase our coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobbeSneyders RobbeSneyders

Labels
CI/CD Related to CI/CD of the repository
Projects
Fondant development
Archived in project
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Add coverage check ml6team/fondant
1 participant
@RobbeSneyders