Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quantization of all 0s #1028

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fix quantization of all 0s #1028

merged 2 commits into from
Apr 24, 2024

Conversation

angeloskath
Copy link
Member

Set the minimum scale to 1e-7 so that the bias doesn't become nan if the scale is 0.

@angeloskath angeloskath requested a review from awni April 23, 2024 20:18
awni
awni approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@awni awni mentioned this pull request Apr 23, 2024
Closed
@angeloskath angeloskath merged commit ec8578d into main Apr 24, 2024
3 checks passed
@angeloskath angeloskath deleted the fix-quant branch April 24, 2024 07:40
@awni awni mentioned this pull request Apr 24, 2024
Closed
Rifur13 pushed a commit to Rifur13/mlx that referenced this pull request Apr 24, 2024
@angeloskath @Rifur13
Fix quantization of all 0s (ml-explore#1028)
d28a4f6
@awni awni mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angeloskath @awni