Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize not working with phi-3 #726

Closed
ivanfioravanti opened this issue Apr 25, 2024 · 3 comments
Closed

Colorize not working with phi-3 #726

ivanfioravanti opened this issue Apr 25, 2024 · 3 comments

Comments

@ivanfioravanti
Copy link
Contributor

I was testing logits probability with few models using --colorize and I noticed that phi-3 is not working

Colorize not working on phi-3 model
@awni
Copy link
Member

awni commented Apr 25, 2024

I just re-uploaded a fixed quantized version that should work now. There was a problem quantizing all zeros that broke the probabilities that was recently fixed ml-explore/mlx#1028

Screenshot 2024-04-25 at 7 13 23 AM

@awni
Copy link
Member

awni commented Apr 25, 2024

If it's still an issue, lmk and I will reopen.

@awni awni closed this as completed Apr 25, 2024
@ivanfioravanti
Copy link
Contributor Author

Thanks! it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants