Skip to content

Fix iOS 26.2 launch crash from Logger.isEnabled - #494

Open
pmanot wants to merge 1 commit into
ml-explore:mainfrom
pmanot:fix/ios26.2-log-crash
Open

pmanot wants to merge 1 commit into
ml-explore:mainfrom
pmanot:fix/ios26.2-log-crash

Conversation

@pmanot

@pmanot pmanot commented Sep 29, 2026

Copy link
Copy Markdown

Proposed changes

Fixes #491. OSLogHandler now uses OSLog.isEnabled(type:) for level checks, avoiding the absent Logger.isEnabled(type:) symbol on iOS 26.2.

Tested with the iOS 26.2 simulator.

Checklist

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@davidkoski

Copy link
Copy Markdown
Member

I like this approach -- better than what I ended up with in #494. Once #495 is merged, I will rebase this on main and remove the 494 (+ pieces of 495) code.

@davidkoski
davidkoski self-requested a review September 30, 2026 20:35
@pmanot

pmanot commented Oct 1, 2026

Copy link
Copy Markdown
Author

better than what I ended up with in #494

I think this may be a typo, did you mean #493?

@davidkoski

Copy link
Copy Markdown
Member

Yeah, typo :-)

@davidkoski davidkoski mentioned this pull request Oct 5, 2026
7 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 0.32.2 causes iOS app to crash at launch on a physical iPhone running iOS 26.2

2 participants