fix: Make limiting depth in traverse() actually work #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asb
force-pushed
the
traverse-depth-fix
branch
from
866221c
to
8122c8f
Compare
pbodnar
reviewed
Sep 4, 2022
Due to a typo (inverted comparison), the test for the traversal depth would always fail. Fix that typo and add test coverage.
asb
force-pushed
the
traverse-depth-fix
branch
from
8122c8f
to
058a51e
Compare
|
Thanks, typo fixed. |
|
Merged, thank you! |
Merged
asb
added a commit
to muxup/muxup-site
that referenced
this pull request
Feb 27, 2023
…se is fixed Now my fixes <miyuchina/mistletoe#157> <miyuchina/mistletoe#158> <miyuchina/mistletoe#159> are in a released version, just use the upstream traverse implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a typo (inverted comparison), the test for the traversal depth would always fail. Fix that typo and add test coverage.