fix: Apply traverse class filter to source when include_source=True #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any class filter given to `traverse` wouldn't be respected for the source node (returned if `include_source=True`). This patch addresses this, and also adds a test for traverse with no additional arguments. This is considered a bug fix as opposed to a breaking change because: * Filtering by class was broken anyway in the last mistletoe release. * It is unintuitive and likely unintended for the filter not to apply to the source node.
asb
force-pushed
the
change-traverse-include-source
branch
from
05b3a0a
to
cfaec86
Compare
|
@asb, a pro work, thank you :) |
Merged
asb
added a commit
to muxup/muxup-site
that referenced
this pull request
Feb 27, 2023
…se is fixed Now my fixes <miyuchina/mistletoe#157> <miyuchina/mistletoe#158> <miyuchina/mistletoe#159> are in a released version, just use the upstream traverse implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any class filter given to
traversewouldn't be respectedfor the source node (returned if
include_source=True). This patchaddresses this.
This is considered a bug fix as opposed to a breaking change because:
the source node.