Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis: Add support for overriding variable/constant BPM on a per-track basis #10931

Merged
merged 11 commits into from
Oct 5, 2022
Merged

Analysis: Add support for overriding variable/constant BPM on a per-track basis #10931

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
463d318
AnalyzerTrack: Add AnalyzerTrack
fwcd Sep 29, 2022
03a9c48
AnalyzerTrack: Use it instead of TrackPointers
fwcd Sep 29, 2022
328fe81
AnalyzerScheduledTrack: Add AnalyzerScheduledTrack
fwcd Sep 29, 2022
2ab9e7d
AnalyzerScheduledTrack: Use it instead of track ids
fwcd Sep 29, 2022
6435194
WTrackMenu: Add ability to pass analysis options
fwcd Sep 29, 2022
19b3cd7
AnalyzerBeats: Respect AnalyzerTrack::Options::useFixedTempo
fwcd Sep 29, 2022
06804bf
WTrackMenu: Add fixed/variable bpm reanalysis actions
fwcd Sep 29, 2022
163cee6
AnalyzerTrack: Pass it by const reference
fwcd Sep 29, 2022
df228e4
WTrackMenu: Hide the redundant reanalysis action
fwcd Oct 3, 2022
c04bae8
AnalyzerTrack: Assert non-nullness and return track by ref
fwcd Oct 4, 2022
a1848e1
Analyzer: Apply style suggestions as per PR review
fwcd Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AnalyzerBeats: Respect AnalyzerTrack::Options::useFixedTempo
  • Loading branch information
@fwcd
fwcd committed Oct 4, 2022
commit 19b3cd7942a77b0f483e1a5f14bc94ffe3223628
3 changes: 2 additions & 1 deletion src/analyzer/analyzerbeats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ bool AnalyzerBeats::initialize(AnalyzerTrack track,
return false;
}

m_bPreferencesFixedTempo = m_bpmSettings.getFixedTempoAssumption();
m_bPreferencesFixedTempo = track.getOptions().useFixedTempo.value_or(
m_bpmSettings.getFixedTempoAssumption());
m_bPreferencesReanalyzeOldBpm = m_bpmSettings.getReanalyzeWhenSettingsChange();
m_bPreferencesReanalyzeImported = m_bpmSettings.getReanalyzeImported();
m_bPreferencesFastAnalysis = m_bpmSettings.getFastAnalysis();
Expand Down