AnalyzerTrack: Pass it by const reference

...to make clazy happy!

src/analyzer/analyzer.h

@@ -23,7 +23,7 @@ class Analyzer {
     //  1. Check if the track needs to be analyzed, otherwise return false.
     //  2. Perform the initialization and return true on success.
     //  3. If the initialization failed log the internal error and return false.
-    virtual bool initialize(AnalyzerTrack tio,
+    virtual bool initialize(const AnalyzerTrack& tio,
             mixxx::audio::SampleRate sampleRate,
             int totalSamples) = 0;
 
@@ -70,7 +70,9 @@ class AnalyzerWithState final {
         return m_active;
     }
 
-    bool initialize(AnalyzerTrack tio, mixxx::audio::SampleRate sampleRate, int totalSamples) {
+    bool initialize(const AnalyzerTrack& tio,
+            mixxx::audio::SampleRate sampleRate,
+            int totalSamples) {
         DEBUG_ASSERT(!m_active);
         return m_active = m_analyzer->initialize(tio, sampleRate, totalSamples);
     }
@@ -86,7 +88,7 @@ class AnalyzerWithState final {
         }
     }
 
-    void finish(AnalyzerTrack tio) {
+    void finish(const AnalyzerTrack& tio) {
         if (m_active) {
             m_analyzer->storeResults(tio.getTrack());
             m_analyzer->cleanup();

src/analyzer/analyzerbeats.cpp

@@ -42,7 +42,7 @@ AnalyzerBeats::AnalyzerBeats(UserSettingsPointer pConfig, bool enforceBpmDetecti
           m_iCurrentSample(0) {
 }
 
-bool AnalyzerBeats::initialize(AnalyzerTrack track,
+bool AnalyzerBeats::initialize(const AnalyzerTrack& track,
         mixxx::audio::SampleRate sampleRate,
         int totalSamples) {
     if (totalSamples == 0) {

src/analyzer/analyzerbeats.h

@@ -27,7 +27,7 @@ class AnalyzerBeats : public Analyzer {
     static QList<mixxx::AnalyzerPluginInfo> availablePlugins();
     static mixxx::AnalyzerPluginInfo defaultPlugin();
 
-    bool initialize(AnalyzerTrack track,
+    bool initialize(const AnalyzerTrack& track,
             mixxx::audio::SampleRate sampleRate,
             int totalSamples) override;
     bool processSamples(const CSAMPLE *pIn, const int iLen) override;

src/analyzer/analyzerebur128.cpp

@@ -21,7 +21,7 @@ AnalyzerEbur128::~AnalyzerEbur128() {
     cleanup(); // ...to prevent memory leaks
 }
 
-bool AnalyzerEbur128::initialize(AnalyzerTrack tio,
+bool AnalyzerEbur128::initialize(const AnalyzerTrack& tio,
         mixxx::audio::SampleRate sampleRate,
         int totalSamples) {
     if (m_rgSettings.isAnalyzerDisabled(2, tio.getTrack()) || totalSamples == 0) {

src/analyzer/analyzerebur128.h

@@ -15,7 +15,7 @@ class AnalyzerEbur128 : public Analyzer {
         return rgSettings.isAnalyzerEnabled(2);
     }
 
-    bool initialize(AnalyzerTrack track,
+    bool initialize(const AnalyzerTrack& track,
             mixxx::audio::SampleRate sampleRate,
             int totalSamples) override;
     bool processSamples(const CSAMPLE* pIn, const int iLen) override;

src/analyzer/analyzergain.cpp

@@ -20,7 +20,7 @@ AnalyzerGain::~AnalyzerGain() {
     delete m_pReplayGain;
 }
 
-bool AnalyzerGain::initialize(AnalyzerTrack tio,
+bool AnalyzerGain::initialize(const AnalyzerTrack& tio,
         mixxx::audio::SampleRate sampleRate,
         int totalSamples) {
     if (m_rgSettings.isAnalyzerDisabled(1, tio.getTrack()) || totalSamples == 0) {

src/analyzer/analyzergain.h

@@ -23,7 +23,7 @@ class AnalyzerGain : public Analyzer {
         return rgSettings.isAnalyzerEnabled(1);
     }
 
-    bool initialize(AnalyzerTrack track,
+    bool initialize(const AnalyzerTrack& track,
             mixxx::audio::SampleRate sampleRate,
             int totalSamples) override;
     bool processSamples(const CSAMPLE* pIn, const int iLen) override;

src/analyzer/analyzerkey.cpp

@@ -42,7 +42,7 @@ AnalyzerKey::AnalyzerKey(const KeyDetectionSettings& keySettings)
           m_bPreferencesReanalyzeEnabled(false) {
 }
 
-bool AnalyzerKey::initialize(AnalyzerTrack tio,
+bool AnalyzerKey::initialize(const AnalyzerTrack& tio,
         mixxx::audio::SampleRate sampleRate,
         int totalSamples) {
     if (totalSamples == 0) {

src/analyzer/analyzerkey.h

@@ -20,7 +20,7 @@ class AnalyzerKey : public Analyzer {
     static QList<mixxx::AnalyzerPluginInfo> availablePlugins();
     static mixxx::AnalyzerPluginInfo defaultPlugin();
 
-    bool initialize(AnalyzerTrack tio,
+    bool initialize(const AnalyzerTrack& tio,
             mixxx::audio::SampleRate sampleRate,
             int totalSamples) override;
     bool processSamples(const CSAMPLE *pIn, const int iLen) override;

src/analyzer/analyzersilence.cpp

@@ -33,7 +33,7 @@ AnalyzerSilence::AnalyzerSilence(UserSettingsPointer pConfig)
           m_iSignalEnd(-1) {
 }
 
-bool AnalyzerSilence::initialize(AnalyzerTrack track,
+bool AnalyzerSilence::initialize(const AnalyzerTrack& track,
         mixxx::audio::SampleRate sampleRate,
         int totalSamples) {
     Q_UNUSED(sampleRate);

src/analyzer/analyzersilence.h

@@ -11,7 +11,7 @@ class AnalyzerSilence : public Analyzer {
     explicit AnalyzerSilence(UserSettingsPointer pConfig);
     ~AnalyzerSilence() override = default;
 
-    bool initialize(AnalyzerTrack track,
+    bool initialize(const AnalyzerTrack& track,
             mixxx::audio::SampleRate sampleRate,
             int totalSamples) override;
     bool processSamples(const CSAMPLE* pIn, const int iLen) override;

src/analyzer/analyzerthread.cpp

@@ -187,7 +187,7 @@ void AnalyzerThread::doRun() {
     emitProgress(AnalyzerThreadState::Exit);
 }
 
-bool AnalyzerThread::submitNextTrack(AnalyzerTrack nextTrack) {
+bool AnalyzerThread::submitNextTrack(const AnalyzerTrack& nextTrack) {
     DEBUG_ASSERT(nextTrack.getTrack());
     kLogger.debug()
             << "Enqueueing next track"

src/analyzer/analyzerthread.h

@@ -77,7 +77,7 @@ class AnalyzerThread : public WorkerThread {
     // with state Idle has been received to avoid overwriting
     // a previously sent track that has not been received by the
     // worker thread, yet.
-    bool submitNextTrack(AnalyzerTrack nextTrack);
+    bool submitNextTrack(const AnalyzerTrack& nextTrack);
 
   signals:
     // Use a single signal for progress updates to ensure that all signals

src/analyzer/analyzerwaveform.cpp

@@ -34,7 +34,7 @@ AnalyzerWaveform::~AnalyzerWaveform() {
     destroyFilters();
 }
 
-bool AnalyzerWaveform::initialize(AnalyzerTrack tio,
+bool AnalyzerWaveform::initialize(const AnalyzerTrack& tio,
         mixxx::audio::SampleRate sampleRate,
         int totalSamples) {
     if (totalSamples == 0) {

src/analyzer/analyzerwaveform.h

@@ -141,7 +141,7 @@ class AnalyzerWaveform : public Analyzer {
             const QSqlDatabase& dbConnection);
     ~AnalyzerWaveform() override;
 
-    bool initialize(AnalyzerTrack tio,
+    bool initialize(const AnalyzerTrack& tio,
             mixxx::audio::SampleRate sampleRate,
             int totalSamples) override;
     bool processSamples(const CSAMPLE* buffer, const int bufferLength) override;

src/analyzer/trackanalysisscheduler.h

@@ -101,7 +101,7 @@ class TrackAnalysisScheduler : public QObject {
             return m_analyzerProgress;
         }
 
-        bool submitNextTrack(AnalyzerTrack track) {
+        bool submitNextTrack(const AnalyzerTrack& track) {
             DEBUG_ASSERT(m_thread);
             return m_thread->submitNextTrack(std::move(track));
         }