Bump rubocop to ruby 2.3, fix all warnings raised in the new version.

.rubocop.yml

@@ -7,7 +7,6 @@ AllCops:
     - 'log/**/*'
     - 'test/**/*'
     - 'vendor/**/*'
-  TargetRubyVersion: 2.2
 Rails:
   Enabled: true
 

Gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 source 'https://rubygems.org'
 
 ruby '2.3.1'

Rakefile

@@ -1,4 +1,5 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

app/controllers/achievements_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class AchievementsController < ApplicationController
   def index
     @achievements = @game.achievements.order(:text)

app/controllers/application_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class ApplicationController < ActionController::Base
   protect_from_forgery with: :exception
 

app/controllers/challenges_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class ChallengesController < ApplicationController
   before_action :enforce_access
   before_action :find_challenge, except: :index

app/controllers/games_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class GamesController < ApplicationController
   helper :all
 

app/controllers/messages_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class MessagesController < ApplicationController
   def index
     @messages = @game.messages.order(:updated_at).reverse_order.page(params[:page]).per(10)

app/controllers/sessions_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class SessionsController < Devise::SessionsController
   skip_before_action :verify_authenticity_token, only: [:new, :create], if: :json_request?
   respond_to :json

app/controllers/timeline_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class TimelineController < ApplicationController
   def index
     # Grab a set of flags submitted and group them by minutes

app/controllers/users_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class UsersController < ApplicationController
   before_action :enforce_access, only: [:download]
 

app/helpers/application_helper.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 module ApplicationHelper
 end

app/helpers/categories_helper.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 module CategoriesHelper
 end

app/helpers/challenges_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ChallengesHelper
   def embed(youtube_url)
     youtube_id = youtube_url.split('v=').last

app/helpers/games_helper.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 module GamesHelper
 end

app/helpers/messages_helper.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 module MessagesHelper
 end

app/helpers/sessions_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SessionsHelper
   def deny_access
     store_location

app/helpers/timeline_helper.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 module TimelineHelper
 end

app/models/achievement.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Achievement < FeedItem
   validates :text, presence: true, uniqueness: true
 

app/models/admin.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 class Admin < User
 end

app/models/category.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Category < ActiveRecord::Base
   belongs_to :game
 

app/models/challenge.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Challenge < ActiveRecord::Base
   after_create :add_states_to_challenges
 
@@ -32,7 +33,7 @@ def open?(division)
   end
 
   def solved?
-    (SolvedChallenge.where('challenge_id = :challenge', challenge: self).count > 0)
+    SolvedChallenge.where('challenge_id = :challenge', challenge: self).count.positive?
   end
 
   # Returns whether or not challenge is available to be opened.

app/models/challenge_state.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class ChallengeState < ActiveRecord::Base
   before_validation :default_values
   belongs_to :challenge

app/models/division.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Division < ActiveRecord::Base
   after_create :add_states_to_challenges
 

app/models/feed_item.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class FeedItem < ActiveRecord::Base
   belongs_to :player, foreign_key: :user_id
   belongs_to :challenge

app/models/flag.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Flag < ActiveRecord::Base
   belongs_to :challenge, inverse_of: :flags
 

app/models/game.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Game < ActiveRecord::Base
   # players
   has_many :players, through: :divisions

app/models/message.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Message < ActiveRecord::Base
   belongs_to :game
   validates :text, :game_id, :title, presence: true

app/models/player.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Player < User
   belongs_to :division
 

app/models/score_adjustment.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class ScoreAdjustment < FeedItem
   include ActionView::Helpers::TextHelper
 
@@ -10,7 +11,7 @@ def description
     color = ''
     verb = ''
     points = point_value
-    if points < 0
+    if points.negative?
       color = 'red'
       verb = 'decreased'
     else
@@ -22,7 +23,7 @@ def description
   # rubocop:enable MethodLength
 
   def icon
-    point_value < 0 ? 'chevron-down' : 'chevron-up'
+    point_value.negative? ? 'chevron-down' : 'chevron-up'
   end
 
   def point_value_is_not_zero

app/models/solved_challenge.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class SolvedChallenge < FeedItem
   validates :challenge_id, :flag, :division_id, :player, presence: true
   validate :user_has_not_solved_challenge, :challenge_is_open, :game_is_open
@@ -24,7 +25,7 @@ def game_is_open
   end
 
   def user_has_not_solved_challenge
-    if player.solved_challenges.where('challenge_id = ?', challenge.id).count > 0
+    if player.solved_challenges.where('challenge_id = ?', challenge.id).count.positive?
       errors.add(:base, I18n.t('challenge.already_solved'))
     end
   end

app/models/submitted_flag.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class SubmittedFlag < ActiveRecord::Base
   belongs_to :player, foreign_key: :user_id
   belongs_to :challenge

app/models/user.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class User < ActiveRecord::Base
   # Include default devise modules. Others available are:
   # :token_authenticatable, :encryptable, :confirmable, :lockable, :timeoutable and :omniauthable

app/views/games/show.json.jbuilder

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 json.array!(@game.players) do |json, player|
   json.name player.name
   json.tags player.tags

bin/bundle

@@ -1,3 +1,4 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
 load Gem.bin_path('bundler', 'bundle')

bin/rails

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 APP_PATH = File.expand_path('../../config/application', __FILE__)
 require_relative '../config/boot'
 require 'rails/commands'

bin/rake

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 require_relative '../config/boot'
 require 'rake'
 Rake.application.run

bin/setup

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 require 'pathname'
 
 # path to your application root.

config.ru

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This file is used by Rack-based servers to start the application.
 
 require ::File.expand_path('../config/environment', __FILE__)

config/application.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path('../boot', __FILE__)
 
 require 'rails/all'

config/boot.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rubygems'
 
 # Set up gems listed in the Gemfile.

config/environment.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Load the rails application
 require File.expand_path('../application', __FILE__)
 

config/environments/development.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Scoreboard::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

config/environments/production.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Scoreboard::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

config/environments/test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Scoreboard::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

config/routes.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Scoreboard::Application.routes.draw do
   # admin
   mount RailsAdmin::Engine => '/admin', :as => 'rails_admin'

lib/tasks/cucumber.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # IMPORTANT: This file is generated by cucumber-rails - edit at your own peril.
 # It is recommended to regenerate this file in the future when you upgrade to a
 # newer version of cucumber-rails. Consider adding your own code to a new file

lib/tasks/scoreboard.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 namespace :scoreboard do
   namespace :user do
     desc 'Add a user to the Game'

script/rails

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 # This command will automatically be run when you run "rails" with Rails 3
 gems installed from the root of your application.