Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support get miniojob error by kubectl #2243

Merged
merged 4 commits into from
Jul 29, 2024
Merged

feat: support get miniojob error by kubectl #2243

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e7cc2f
log the error before return
Jul 26, 2024
717677d
refactor log
Jul 26, 2024
a13a9fe
fields
Jul 26, 2024
a08b2cb
Apply suggestions from code review
jiuker Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
log the error before return 
log the error before return
  • Loading branch information
jiuker committed Jul 26, 2024
commit 9e7cc2f17f4b6e7d434cde7274e0a057b3d149b6
2 changes: 2 additions & 0 deletions pkg/controller/job-controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ func (c *JobController) SyncHandler(key string) (Result, error) {
if err != nil {
jobCR.Status.Phase = miniojob.MinioJobPhaseError
jobCR.Status.Message = fmt.Sprintf("Get tenant %s/%s error:%v", jobCR.Spec.TenantRef.Namespace, jobCR.Spec.TenantRef.Name, err)
klog.Errorln(jobCR.Status.Message)
err = c.updateJobStatus(ctx, &jobCR)
return WrapResult(Result{}, err)
}
Expand Down Expand Up @@ -264,6 +265,7 @@ func (c *JobController) SyncHandler(key string) (Result, error) {
if err != nil {
jobCR.Status.Phase = miniojob.MinioJobPhaseError
jobCR.Status.Message = fmt.Sprintf("Create job error:%v", err)
klog.Errorln(jobCR.Status.Message)
err = c.updateJobStatus(ctx, &jobCR)
return WrapResult(Result{}, err)
}
Expand Down
Loading