Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support get miniojob error by kubectl #2243

Merged
merged 4 commits into from
Jul 29, 2024
Merged

feat: support get miniojob error by kubectl #2243

merged 4 commits into from
Jul 29, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Jul 26, 2024 •
edited
Loading

log the error before return when create minio job error.
The error will be overwriten by c.updateJobStatus(ctx, &jobCR) before.
Now we can do

$ kubectl get minioJob -A
NAMESPACE        NAME             PHASE   MESSAGE
minio-operator   minio-test-job   Error   no policybinding found

jiuker added 3 commits July 26, 2024 16:12
log the error before return
9e7cc2f 
log the error before return
refactor log
717677d 
refactor log
fields
a13a9fe
@jiuker jiuker requested review from pjuarezd and cniackz and removed request for pjuarezd July 26, 2024 09:02
@jiuker jiuker changed the title log: log the error before return when create minio job error feat: support get miniojob error by kubectl Jul 26, 2024
pjuarezd
pjuarezd previously approved these changes Jul 26, 2024
View reviewed changes
ramondeklein
ramondeklein requested changes Jul 26, 2024
View reviewed changes
pkg/controller/job-controller.go Show resolved Hide resolved
pkg/controller/job-controller.go Outdated Show resolved Hide resolved
pkg/controller/job-controller.go Outdated Show resolved Hide resolved
pkg/controller/job-controller.go Outdated Show resolved Hide resolved
pkg/controller/job-controller.go Outdated Show resolved Hide resolved
pkg/controller/job-controller.go Outdated Show resolved Hide resolved
@jiuker @ramondeklein
Apply suggestions from code review
a08b2cb 
Co-authored-by: Ramon de Klein <mail@ramondeklein.nl>
@jiuker jiuker requested a review from ramondeklein July 26, 2024 13:41
@jiuker jiuker merged commit 7f53934 into minio:master Jul 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramondeklein ramondeklein ramondeklein approved these changes

@shtripat shtripat shtripat approved these changes

@pjuarezd pjuarezd pjuarezd left review comments

@cniackz cniackz Awaiting requested review from cniackz

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiuker @pjuarezd @ramondeklein @shtripat