Fix: cache clientIP in GetConsoleHTTPClient #3056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Sep 21, 2023
dvaldivia
requested review from
allanrogerr,
bexsoft,
cesnietor,
cniackz,
dilverse and
pjuarezd
|
I tested the fix, it does addresses the problem, but let's remove the http client cache and make the casting of the transport more defensive |
harshavardhana
previously requested changes
Sep 26, 2023
dvaldivia
previously approved these changes
Oct 9, 2023
bexsoft
approved these changes
Oct 9, 2023
dvaldivia
dismissed
harshavardhana’s stale review
There's no global storage of the client anymore
Merged
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3010
Changes:
This was tested using the provided nginx configuration from the following discussion
( minio/minio#17878 (comment))
Local test environment, using LXC ( Ubuntu 22.04 ):