Skip to content

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Sep 13, 2023

fixes #3028

What does this do?

  • Fixed LDAP Enabled / Disabled calculation
  • Removed Password Label from main page to avoid confusion
  • Added Re-enter password notice to edit configurations page as this is required for security purposes
  • Display LDAP ENV variables in case of configured

How does it look?

Screenshot 2023-09-13 at 17 31 09 Screenshot 2023-09-13 at 17 26 54 Screenshot 2023-09-13 at 17 21 06 Screenshot 2023-09-13 at 17 18 54 Screenshot 2023-09-13 at 17 17 59 Screenshot 2023-09-13 at 17 17 33 Screenshot 2023-09-13 at 17 17 30 Screenshot 2023-09-13 at 17 17 27

@cesnietor
Copy link
Collaborator

I'd say that we should disable the other buttons since if you click on them before restarting.
Screenshot 2023-09-14 at 3 13 01 PM
An example of clicking refresh:
Screenshot 2023-09-14 at 3 17 41 PM
Also it's worth noting that if you dismiss the restart button, there's no other way to restart the server other than that message, we might have to allow that functionality (enhancement) somewhere else cause it can be easily dismissed.

@cesnietor
Copy link
Collaborator

If you click Edit Configuration and then define the password and click Save.
Then you click again on Edit Configuration, the password is still there.
Shouldn't we forget it every time you click on Edit? since we do a post when we do Save.?
Screenshot 2023-09-14 at 3 15 18 PM

@bexsoft
Copy link
Collaborator Author

bexsoft commented Sep 14, 2023

I'd say that we should disable the other buttons since if you click on them before restarting. Screenshot 2023-09-14 at 3 13 01 PM An example of clicking refresh: Screenshot 2023-09-14 at 3 17 41 PM Also it's worth noting that if you dismiss the restart button, there's no other way to restart the server other than that message, we might have to allow that functionality (enhancement) somewhere else cause it can be easily dismissed.

I'd say that we should disable the other buttons since if you click on them before restarting. Screenshot 2023-09-14 at 3 13 01 PM An example of clicking refresh: Screenshot 2023-09-14 at 3 17 41 PM Also it's worth noting that if you dismiss the restart button, there's no other way to restart the server other than that message, we might have to allow that functionality (enhancement) somewhere else cause it can be easily dismissed.

We would need to discuss this restart banner as it can cause some other UX issues in other parts of the application

- Fixed LDAP Enabled / Disabled calculation
- Removed Password Label from main page to avoid confusion
- Display LDAP ENV variables in case of configured

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft
Copy link
Collaborator Author

bexsoft commented Sep 14, 2023

If you click Edit Configuration and then define the password and click Save. Then you click again on Edit Configuration, the password is still there. Shouldn't we forget it every time you click on Edit? since we do a post when we do Save.? Screenshot 2023-09-14 at 3 15 18 PM

Fixed

@bexsoft bexsoft merged commit f058095 into minio:master Sep 14, 2023
@bexsoft bexsoft deleted the ldap-ux-fixes branch September 15, 2023 06:07
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
- Fixed LDAP Enabled / Disabled calculation
- Removed Password Label from main page to avoid confusion
- Display LDAP ENV variables in case of configured

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
- Fixed LDAP Enabled / Disabled calculation
- Removed Password Label from main page to avoid confusion
- Display LDAP ENV variables in case of configured

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LDAP configuration acts like it saves, but then reverts after refresh

3 participants