Skip to content

Changed Download Handler Behavior #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2023
Merged

Changed Download Handler Behavior #2964

merged 1 commit into from
Jul 27, 2023

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Jul 27, 2023 •
edited
Loading

fixes #2961
fixes #2957

What does this do?

  • Remove StreamSaver library
  • Updated Handler for files with size of 49GB or less
  • Used Browser Handler tor size of more than 50GB

@bexsoft bexsoft self-assigned this Jul 27, 2023
Changed Download Handler Behavior
35dd913 
- Updated Handler for files with size of 49GB or less
- Used Browser Handler tor size of more than 50GB

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
harshavardhana
harshavardhana reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the logic behind this can you explain a bit?

@bexsoft
Copy link
Collaborator Author

bexsoft commented Jul 27, 2023 •
edited
Loading

What is the logic behind this can you explain a bit?

Sure, Basically we changed the Download manager to use the original method that we had before to handle the objects downloads.

  • We create a local HTTP request, add the listeners necessary to show the information in the object manager (Progress, Errors, File download complete & the ability to cancel the download)
  • The new thing that was added is to use the browser native download manager in case the file you are trying to download is bigger than 50GB (this is to avoid "Network error occured" when downloading large file #2760)

@harshavardhana harshavardhana merged commit 3ce377d into minio:master Jul 27, 2023
@prakashsvmx prakashsvmx mentioned this pull request Jul 27, 2023
Closed
@prakashsvmx prakashsvmx mentioned this pull request Aug 11, 2023
Closed
@bexsoft bexsoft deleted the remove-stream branch January 10, 2025 20:44
@marktheunissen marktheunissen mentioned this pull request May 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@reivaj05 reivaj05 reivaj05 approved these changes

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@cniackz cniackz Awaiting requested review from cniackz

@cesnietor cesnietor Awaiting requested review from cesnietor

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@kannappanr kannappanr Awaiting requested review from kannappanr

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@dilverse dilverse Awaiting requested review from dilverse

Assignees

@bexsoft bexsoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StreamSaver.js leaks incorrect URL information via web console Can't download file from console when github unavailable

3 participants

@bexsoft @harshavardhana @reivaj05