Add eval script for benchmarking multiple datasets #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamitHuang
reviewed
Apr 27, 2023
tools/eval_benchmark.py
Outdated
There was a problem hiding this comment.
脚本易与eval.py混淆，需要作调整，放在tools/benchmarking/multi_dataset_eval.py
同时，在.py docstring 或 tools/benchmarking/README.md 中给出usage.
SamitHuang
reviewed
May 2, 2023
| postprocessor=postprocessor, | ||
| metrics=[metric], | ||
| num_columns_to_net=dataset_config.get('num_columns_to_net', 1), | ||
| num_columns_of_labels=dataset_config.get('num_columns_of_labels', None), |
|
|
||
| else: | ||
| net_evaluator.reload( | ||
| loader_eval, |
HaoyangLee
approved these changes
May 3, 2023
SamitHuang
reviewed
May 3, 2023
There was a problem hiding this comment.
这个评估脚本在crnn中的评估使用，请加到configs/rec/crnn的readme中。
There was a problem hiding this comment.
好的，会在 #191 中添加这部分的说明
zhtmike
reviewed
May 5, 2023
| import os | ||
| import copy | ||
| __dir__ = os.path.dirname(os.path.abspath(__file__)) | ||
| sys.path.insert(0, os.path.abspath(os.path.join(__dir__, ".."))) |
There was a problem hiding this comment.
因为是在主目录第二层， 所以应该是 sys.path.insert(0, os.path.abspath(os.path.join(__dir__, "../..")))
zhtmike
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
(Write your motivation for proposed changes here.)
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)