-
Notifications
You must be signed in to change notification settings - Fork 60
Update CRNN readme #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CRNN readme #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to merge as one commit.
参数配置文档,单独提一个PR。
configs/rec/crnn/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里补充下 training set, validation set分别多少张images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inference的数据也合进去。分Training performance 和 Inference performance两张表。
configs/参数配置文档说明.md
Outdated
| num_workers | 指定 batch 操作的并发进程数/线程数 | 8 | 该值应大于或等于2 | | ||
|
||
|
||
### 评估流程 (eval) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议新增num_columns_of_labels
参数说明。参考PR #207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已更新并另开了一个单独的PR #212
针对之前文档中模糊不清的部分,细化了一些介绍:
[419更新]
[420更新]
文档在有一些冗余的部分,根据个人理解有一些删减,请review,thanks!
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
(Write your motivation for proposed changes here.)
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)