Skip to content

Update CRNN readme #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 5, 2023
Merged

Update CRNN readme #191

merged 19 commits into from
May 5, 2023

Conversation

hqkate
Copy link
Collaborator

@hqkate hqkate commented Apr 17, 2023

针对之前文档中模糊不清的部分,细化了一些介绍:

  1. 添加了 dataset usage 部分介绍各数据集的用途及评估的操作步骤以便读者复现结果
  2. 评估结果中添加了一列说明 字典字符

[419更新]

  1. 增加了benchmark数据:IIIT, SVT, IC03, IC13, IC15, SVTP, CUTE 分别的精度
  2. 增加了 configs/参数配置文档说明.md
  3. 增加了默认字典及自定义字典说明

[420更新]

  1. 添加了性能数据

文档在有一些冗余的部分,根据个人理解有一些删减,请review,thanks!

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

Motivation

(Write your motivation for proposed changes here.)

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@SamitHuang SamitHuang self-requested a review April 17, 2023 08:45
Copy link
Collaborator

@SamitHuang SamitHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamitHuang SamitHuang requested a review from HaoyangLee April 24, 2023 07:28
Copy link
Collaborator

@SamitHuang SamitHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to merge as one commit.
参数配置文档,单独提一个PR。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里补充下 training set, validation set分别多少张images.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inference的数据也合进去。分Training performance 和 Inference performance两张表。

| num_workers | 指定 batch 操作的并发进程数/线程数 | 8 | 该值应大于或等于2 |


### 评估流程 (eval)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议新增num_columns_of_labels参数说明。参考PR #207

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新并另开了一个单独的PR #212

@hqkate hqkate marked this pull request as draft April 27, 2023 07:03
@SamitHuang SamitHuang marked this pull request as ready for review May 3, 2023 07:14
@SamitHuang SamitHuang merged commit 8e27baf into mindspore-lab:main May 5, 2023
@hqkate hqkate deleted the update-readme branch May 12, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants