Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] use the object heap to keep the min ddl ts order #39193

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 90.26549% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.43%. Comparing base (af22644) to head (c140d4e).
Report is 4 commits behind head on 2.4.

Files with missing lines Patch % Lines
pkg/util/typeutil/heap.go 88.76% 8 Missing and 2 partials ⚠️
internal/rootcoord/scheduler.go 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39193      +/-   ##
==========================================
- Coverage   80.44%   80.43%   -0.01%     
==========================================
  Files        1077     1078       +1     
  Lines      169731   169838     +107     
==========================================
+ Hits       136534   136615      +81     
- Misses      28713    28724      +11     
- Partials     4484     4499      +15     
Files with missing lines Coverage Δ
internal/rootcoord/task.go 96.15% <100.00%> (+0.20%) ⬆️
internal/rootcoord/scheduler.go 94.69% <94.11%> (-0.22%) ⬇️
pkg/util/typeutil/heap.go 88.76% <88.76%> (ø)

... and 34 files with indirect coverage changes

@SimFG
Copy link
Contributor Author

SimFG commented Jan 13, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 13, 2025
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0f4e1d1 into milvus-io:2.4 Jan 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants