Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the object heap to keep the min ddl ts order #39118

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jan 9, 2025

issue: #39002

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 9, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 9, 2025
@SimFG SimFG force-pushed the master-rootcoord-ts branch 3 times, most recently from 503d574 to aedbbf6 Compare January 9, 2025 09:48
Signed-off-by: SimFG <bang.fu@zilliz.com>
@SimFG SimFG force-pushed the master-rootcoord-ts branch from aedbbf6 to 1a8905a Compare January 9, 2025 10:26
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 89.55224% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (d6206ad) to head (1a8905a).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/typeutil/heap.go 86.04% 4 Missing and 2 partials ⚠️
internal/rootcoord/scheduler.go 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39118       +/-   ##
===========================================
+ Coverage   69.64%   81.17%   +11.53%     
===========================================
  Files         296     1395     +1099     
  Lines       26633   197276   +170643     
===========================================
+ Hits        18548   160147   +141599     
- Misses       8085    31529    +23444     
- Partials        0     5600     +5600     
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.64% <ø> (ø)
Go 83.11% <89.55%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/task.go 93.18% <100.00%> (ø)
internal/rootcoord/scheduler.go 94.69% <94.11%> (ø)
pkg/util/typeutil/heap.go 93.25% <86.04%> (ø)

... and 1096 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 9, 2025
@chyezh
Copy link
Contributor

chyezh commented Jan 9, 2025

/lgtm

@xiaofan-luan
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 357eaf0 into milvus-io:master Jan 10, 2025
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jan 14, 2025
- issue: #39002
- pr: #39118

Signed-off-by: SimFG <bang.fu@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jan 14, 2025
- issue: #39002
- pr: #39118

Signed-off-by: SimFG <bang.fu@zilliz.com>
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants