Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Read metadata concurrently to accelerate recovery #38900

Merged
merged 10 commits into from
Jan 16, 2025
Merged

enhance: [2.5] Read metadata concurrently to accelerate recovery #38900

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e4e04c7
enhance: Read metadata concurrently to accelerate recovery
bigsheeper Jan 1, 2025
b92032f
fix ut
bigsheeper Jan 1, 2025
4e402a0
fix conflicts
bigsheeper Jan 14, 2025
ce50a7c
fix conflicts
bigsheeper Jan 14, 2025
480fa36
print collectionIDs
bigsheeper Jan 14, 2025
21a8006
Merge branch '2.5' of https://github.com/milvus-io/milvus into 2412-s…
bigsheeper Jan 15, 2025
e2acf3f
code format
bigsheeper Jan 15, 2025
8b2e6fb
Merge branch '2.5' of https://github.com/milvus-io/milvus into 2412-s…
bigsheeper Jan 15, 2025
4d11db1
code format
bigsheeper Jan 15, 2025
c4c82f7
fix conflicts
bigsheeper Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
print collectionIDs 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
  • Loading branch information
@bigsheeper
bigsheeper committed Jan 14, 2025
commit 480fa36abc2942d5bc8ee2062c06ec43d7b3dc99
4 changes: 3 additions & 1 deletion internal/rootcoord/root_coord.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,7 +1344,7 @@ func (c *Core) ShowCollectionIDs(ctx context.Context, in *rootcoordpb.ShowCollec
tr := timerecord.NewTimeRecorder("ShowCollectionIDs")

ts := typeutil.MaxTimestamp
log := log.Ctx(ctx).With(zap.Strings("dbNames", in.GetDbNames()))
log := log.Ctx(ctx).With(zap.Strings("dbNames", in.GetDbNames()), zap.Bool("allowUnavailable", in.GetAllowUnavailable()))

// Currently, this interface is only called during startup, so there is no need to execute it within the scheduler.
var err error
Expand Down Expand Up @@ -1393,6 +1393,8 @@ func (c *Core) ShowCollectionIDs(ctx context.Context, in *rootcoordpb.ShowCollec
metrics.RootCoordDDLReqCounter.WithLabelValues("ShowCollectionIDs", metrics.SuccessLabel).Inc()
metrics.RootCoordDDLReqLatency.WithLabelValues("ShowCollectionIDs").Observe(float64(tr.ElapseSpan().Milliseconds()))

log.Info("ShowCollectionIDs done", zap.Any("collectionIDs", dbCollections))

return &rootcoordpb.ShowCollectionIDsResponse{
Status: merr.Success(),
DbCollections: dbCollections,
Expand Down
Loading