Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Read metadata concurrently to accelerate recovery #38900

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

bigsheeper
Copy link
Contributor

Read metadata such as segments, binlogs, and partitions concurrently at the collection level.

issue: #37630

pr: #38403

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 1, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 89.25926% with 29 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (4cb47b3) to head (c4c82f7).
Report is 5 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/datacoord/meta.go 86.76% 6 Missing and 3 partials ⚠️
internal/metastore/kv/querycoord/kv_catalog.go 80.64% 4 Missing and 2 partials ⚠️
internal/datacoord/server.go 58.33% 3 Missing and 2 partials ⚠️
internal/datacoord/broker/coordinator_broker.go 73.33% 3 Missing and 1 partial ⚠️
internal/metastore/kv/rootcoord/kv_catalog.go 85.18% 3 Missing and 1 partial ⚠️
internal/metastore/kv/datacoord/kv_catalog.go 94.73% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38900      +/-   ##
==========================================
+ Coverage   81.04%   82.87%   +1.83%     
==========================================
  Files        1404     1104     -300     
  Lines      197402   170750   -26652     
==========================================
- Hits       159983   141510   -18473     
+ Misses      31799    23638    -8161     
+ Partials     5620     5602      -18     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.04% <89.25%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/distributed/rootcoord/client/client.go 93.54% <100.00%> (+0.10%) ⬆️
internal/distributed/rootcoord/service.go 81.46% <100.00%> (+1.08%) ⬆️
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/querycoordv2/meta/collection_manager.go 89.74% <100.00%> (+2.99%) ⬆️
internal/rootcoord/meta_table.go 83.35% <100.00%> (+0.05%) ⬆️
internal/rootcoord/root_coord.go 90.13% <100.00%> (+0.23%) ⬆️
internal/util/mock/grpc_rootcoord_client.go 86.04% <100.00%> (+0.21%) ⬆️
pkg/util/paramtable/service_param.go 99.15% <100.00%> (+<0.01%) ⬆️
internal/metastore/kv/datacoord/kv_catalog.go 77.44% <94.73%> (-1.26%) ⬇️
internal/datacoord/broker/coordinator_broker.go 96.22% <73.33%> (-3.78%) ⬇️
... and 4 more

... and 332 files with indirect coverage changes

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 15, 2025
@czs007 czs007 added this to the 2.5.4 milestone Jan 15, 2025
@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify mergify bot removed the ci-passed label Jan 16, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 16, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 16, 2025
@sre-ci-robot sre-ci-robot merged commit 6773fb1 into milvus-io:2.5 Jan 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants