Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Cherry-pick] access log retention new log not the old and skip rotate empty log #38661

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 23, 2024

pr: #38309
relate: #38293

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.43%. Comparing base (7363a1c) to head (a42a517).
Report is 10 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/accesslog/writer.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38661      +/-   ##
==========================================
- Coverage   80.38%   79.43%   -0.96%     
==========================================
  Files        1077     1077              
  Lines      169449   169452       +3     
==========================================
- Hits       136219   134611    -1608     
- Misses      28748    30352    +1604     
- Partials     4482     4489       +7     
Files with missing lines Coverage Δ
internal/proxy/accesslog/writer.go 83.02% <75.00%> (-0.93%) ⬇️

... and 89 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b9eb396 into milvus-io:2.4 Dec 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants