Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: access log remove new log not the old and skip rotate empty log #38309

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: access log remove new log not the old and skip rotate empty log #38309

merged 1 commit into from
Dec 17, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 9, 2024

relate: #38293

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 9, 2024
@aoiasd aoiasd changed the title fix: access log retention new log not the old and skip rotate empty log fix: access log remove new log not the old and skip rotate empty log Dec 9, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (c1f9158) to head (98ece76).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/accesslog/writer.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38309      +/-   ##
==========================================
- Coverage   82.75%   80.81%   -1.94%     
==========================================
  Files        1081     1373     +292     
  Lines      166840   195052   +28212     
==========================================
+ Hits       138061   157638   +19577     
- Misses      23246    31889    +8643     
+ Partials     5533     5525       -8
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 69.37% <ø> (∅)
Go 82.98% <75.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/accesslog/writer.go 83.02% <75.00%> (-0.93%) ⬇️

... and 315 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
fix access log retention new log not the old and skip rotate empty log
98ece76 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@mergify mergify bot added the ci-passed label Dec 13, 2024
congqixia
congqixia approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 93fba1d into milvus-io:master Dec 17, 2024
19 of 20 checks passed
aoiasd added a commit to aoiasd/milvus that referenced this pull request Dec 17, 2024
@aoiasd
fix: access log remove new log not the old and skip rotate empty log (m…
d466281 
…ilvus-io#38309)

relate: milvus-io#38293

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@aoiasd aoiasd mentioned this pull request Dec 17, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

⚠️ The sha of the head commit of this PR conflicts with #38536. Mergify cannot evaluate rules on this PR. ⚠️

@aoiasd aoiasd mentioned this pull request Dec 23, 2024
Merged
aoiasd added a commit to aoiasd/milvus that referenced this pull request Dec 23, 2024
@aoiasd
fix: access log remove new log not the old and skip rotate empty log (m…
a42a517 
…ilvus-io#38309)

relate: milvus-io#38293

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Dec 25, 2024
@aoiasd
fix: [Cherry-pick] access log retention new log not the old and skip …
b9eb396 
…rotate empty log (#38661)

pr: #38309
relate: #38293

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aoiasd @sre-ci-robot @congqixia