Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Invalidate collection cache when release collection (#37577) #37628

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #37577
Related to #37395


…io#37577)

Related to milvus-io#37395

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Nov 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (3456e24) to head (c86ba46).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #37628       +/-   ##
===========================================
+ Coverage   72.24%   83.72%   +11.48%     
===========================================
  Files        1069      801      -268     
  Lines      166736   140288    -26448     
===========================================
- Hits       120451   117451     -3000     
+ Misses      41880    18442    -23438     
+ Partials     4405     4395       -10     
Files with missing lines Coverage Δ
internal/proxy/impl.go 85.56% <100.00%> (ø)
internal/querycoordv2/job/job_release.go 82.40% <100.00%> (+3.15%) ⬆️
internal/querycoordv2/services.go 85.29% <100.00%> (+0.03%) ⬆️

... and 305 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8801322 into milvus-io:2.4 Nov 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants