Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Invalidate collection cache when release collection #37577

Merged

Conversation

congqixia
Copy link
Contributor

Related to #37395

Related to milvus-io#37395

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 11, 2024
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Nov 11, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (fca946d) to head (55d5026).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37577      +/-   ##
==========================================
- Coverage   80.58%   80.57%   -0.02%     
==========================================
  Files        1356     1356              
  Lines      190009   190031      +22     
==========================================
- Hits       153117   153111       -6     
- Misses      31485    31507      +22     
- Partials     5407     5413       +6     
Components Coverage Δ
Client 60.27% <ø> (ø)
Core 68.13% <ø> (ø)
Go 83.21% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/impl.go 85.09% <100.00%> (-0.06%) ⬇️
internal/querycoordv2/job/job_release.go 82.11% <100.00%> (+3.26%) ⬆️
internal/querycoordv2/services.go 86.65% <100.00%> (+0.02%) ⬆️

... and 31 files with indirect coverage changes

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed label Nov 11, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit f5b06a3 into milvus-io:master Nov 12, 2024
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 13, 2024
…io#37577)

Related to milvus-io#37395

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Nov 13, 2024
…37577) (#37628)

Cherry-pick from master
pr: #37577
Related to #37395

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants