Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fp32 vector to fp16/bf16 vector conversion for RESTful API #37556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: fp32 vector to fp16/bf16 vector conversion for RESTful API #37556

wants to merge 1 commit into from
+836 −263

Conversation

jiangyinzuo
Copy link
Contributor

@jiangyinzuo jiangyinzuo commented Nov 8, 2024 •
edited
Loading

RESTful API has 3 handlers. The influenced API are as follows:

  • Handler. insert
  • HandlerV1. insert/upsert
  • HandlerV2. insert/upsert/search

issue: #37448

@sre-ci-robot sre-ci-robot added area/test sig/testing size/L Denotes a PR that changes 100-499 lines. labels Nov 8, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiangyinzuo
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Nov 8, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (61a5b15) to head (53b5480).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (61a5b15) and HEAD (53b5480). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (61a5b15) HEAD (53b5480)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37556       +/-   ##
===========================================
- Coverage   80.59%   68.13%   -12.47%     
===========================================
  Files        1356      290     -1066     
  Lines      190010    25395   -164615     
===========================================
- Hits       153148    17302   -135846     
+ Misses      31460     8093    -23367     
+ Partials     5402        0     -5402
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <ø> (ø)
Go ∅ <ø> (∅)

see 1066 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@jiangyinzuo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Nov 9, 2024
@jiangyinzuo jiangyinzuo force-pushed the feat/fp32-to-fp16-or-bf16 branch 2 times, most recently from 41dc76b to 43c1181 Compare November 9, 2024 07:59
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 9, 2024

@jiangyinzuo go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 9, 2024

@jiangyinzuo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiangyinzuo jiangyinzuo force-pushed the feat/fp32-to-fp16-or-bf16 branch 3 times, most recently from 69831ba to a900400 Compare November 10, 2024 15:53
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2024

@jiangyinzuo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Nov 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@jiangyinzuo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiangyinzuo jiangyinzuo force-pushed the feat/fp32-to-fp16-or-bf16 branch 3 times, most recently from e8c2f3c to 53b5480 Compare November 11, 2024 08:38
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
53b5480 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@jiangyinzuo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

jiangyinzuo
jiangyinzuo commented Nov 11, 2024
View reviewed changes
internal/distributed/proxy/httpserver/wrap_request.go
}
return data
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate function with serialize, so I removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@sunby sunby Awaiting requested review from sunby

Assignees
No one assigned
Labels
area/test dco-passed DCO check passed. kind/feature Issues related to feature request from users sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiangyinzuo @sre-ci-robot