Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we just convert FP32 to fp16 automatically? #37448

Open
liliu-z opened this issue Nov 5, 2024 · 2 comments
Open

should we just convert FP32 to fp16 automatically? #37448

liliu-z opened this issue Nov 5, 2024 · 2 comments
Assignees
@cqy123456

Comments

@liliu-z
Copy link
Member

liliu-z commented Nov 5, 2024

should we just convert FP32 to fp16 automatically?
@smellthemoon @liliu-z @tedxu any thoughts on this?

This is worth debating: If yes, means we modify the data from users' side and store it. Some operations like GetVector's meaning will get hurt. If no, SDK user experience, especially RESTFUL API will suffer

They define their vector as BF16/FP16 already. and there is no easy way to represent BF16/FP16 on most the languages. If data lose accuracy it's user's choice.

If they want to keep original data they should use Fp32 float + Floa16/BF16 quantazition or int8 quantazation in the future

Originally posted by @xiaofan-luan in #37123 (reply in thread)
@liliu-z
Copy link
Member Author

liliu-z commented Nov 5, 2024

/assign @cqy123456

@xiaofan-luan
Copy link
Collaborator

I think this definitely makes user's understanding easier

jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 8, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
033d02f 
issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
@jiangyinzuo jiangyinzuo mentioned this issue Nov 8, 2024
Open
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 8, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
b990bae 
issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 9, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
13cec0b 
RESTful API has 3 handlers. The API changed are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 9, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
41dc76b 
RESTful API has 3 handlers. The API changed are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 9, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
43c1181 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 9, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
fbffef4 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 10, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
69831ba 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 10, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
a900400 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 11, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
bd88e93 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 11, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
8b004b8 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 11, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
3b0152c 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 11, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
e8c2f3c 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 11, 2024
@jiangyinzuo
feat: fp32 vector to fp16/bf16 vector conversion for RESTful API
53b5480 
RESTful API has 3 handlers. The influenced API are as follows:

- Handler. insert
- HandlerV1. insert/upsert
- HandlerV2. insert/upsert/search

issue: milvus-io#37448

Signed-off-by: Yinzuo Jiang <yinzuo.jiang@zilliz.com>
Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqy123456 cqy123456

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cqy123456 @xiaofan-luan @liliu-z