Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cp24]Exlude L0 compaction when clustering is executing #37142

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Oct 25, 2024

Also remove conflit check when executing L0. The exclusive is already guarenteed in scheduler

See also: #37140
pr: #37141

Also remove conflit check when executing L0. The exclusive
is already guarenteed in scheduler

See also: milvus-io#37140

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 25, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby October 25, 2024 06:56
@XuanYang-cn XuanYang-cn added this to the 2.4.14 milestone Oct 25, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Oct 25, 2024
Copy link
Contributor

mergify bot commented Oct 25, 2024

@XuanYang-cn Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Oct 25, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 25, 2024
Copy link
Contributor

mergify bot commented Oct 25, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (9d37ade) to head (de418df).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37142      +/-   ##
==========================================
- Coverage   80.58%   80.58%   -0.01%     
==========================================
  Files        1066     1066              
  Lines      165285   165280       -5     
==========================================
- Hits       133197   133183      -14     
+ Misses      27749    27748       -1     
- Partials     4339     4349      +10     
Files with missing lines Coverage Δ
internal/datacoord/compaction_task_l0.go 94.40% <100.00%> (-2.86%) ⬇️
internal/datacoord/compaction.go 78.55% <50.00%> (+0.04%) ⬆️

... and 23 files with indirect coverage changes

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 28, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4cb5b2c into milvus-io:2.4 Oct 28, 2024
14 of 15 checks passed
@XuanYang-cn XuanYang-cn deleted the cp24/fix-exclusive branch October 28, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants