Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exlude L0 compaction when clustering is executing #37141

Merged
merged 5 commits into from
Oct 28, 2024
Merged

fix: Exlude L0 compaction when clustering is executing #37141

merged 5 commits into from
Oct 28, 2024

Conversation

XuanYang-cn
Copy link
Contributor

Also remove conflit check when executing L0. The exclusive is already guarenteed in scheduler

See also: #37140

@XuanYang-cn
fix: Exlude L0 compaction when clustering is executing
1395a7c 
Also remove conflit check when executing L0. The exclusive
is already guarenteed in scheduler

See also: milvus-io#37140

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn XuanYang-cn mentioned this pull request Oct 25, 2024
Merged
@XuanYang-cn
fix ut
5f94957 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.89%. Comparing base (f87acdf) to head (f87acdf).
Report is 6 commits behind head on master.

❗ Current head f87acdf differs from pull request most recent head ffca28b

Please upload reports for the commit ffca28b to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37141   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files         290      290           
  Lines       25431    25431           
=======================================
  Hits        17011    17011           
  Misses       8420     8420
Components Coverage Δ
Client ∅ <0.00%> (∅)
Core 66.89% <0.00%> (ø)
Go ∅ <0.00%> (∅)

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Oct 28, 2024
@XuanYang-cn
fix: [cp24]Exlude L0 compaction when clustering is executing (#37142)
4cb5b2c 
Also remove conflit check when executing L0. The exclusive is already
guarenteed in scheduler

See also: #37140
pr: #37141

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 28, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 26028f4 into milvus-io:master Oct 28, 2024
14 of 15 checks passed
@XuanYang-cn XuanYang-cn deleted the exclude-cluster-l0 branch October 29, 2024 02:31
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Oct 29, 2024
@XuanYang-cn
fix: Exlude L0 compaction when clustering is executing (milvus-io#37141)
9d17dd5 
Also remove conflit check when executing L0. The exclusive is already
guarenteed in scheduler

See also: milvus-io#37140
pr: milvus-io#37141

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Oct 29, 2024
@XuanYang-cn
fix: [25]Exlude L0 compaction when clustering is executing (milvus-io…
af52d21 
…#37141)

Also remove conflit check when executing L0. The exclusive is already
guarenteed in scheduler

See also: milvus-io#37140
pr: milvus-io#37141

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this pull request Oct 29, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Oct 31, 2024
@XuanYang-cn
fix: [25]Exlude L0 compaction when clustering is executing (#37141) (#…
12fb9d6 
…37230)

Also remove conflit check when executing L0. The exclusive is already
guarenteed in scheduler

See also: #37140
pr: #37141

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuanYang-cn @xiaofan-luan @sre-ci-robot