Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Gin & restfulv1 handler use sonic json #35020

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

haorenfsa
Copy link
Contributor

/cc @czs007 @congqixia
/kind enhancement

@sre-ci-robot sre-ci-robot requested review from congqixia and czs007 July 26, 2024 03:30
@sre-ci-robot sre-ci-robot added kind/enhancement Issues or changes related to enhancement area/compilation size/S Denotes a PR that changes 10-29 lines. labels Jul 26, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jul 26, 2024
Copy link
Contributor

mergify bot commented Jul 26, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: haorenfsa <haorenfsa@gmail.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jul 26, 2024
Copy link
Contributor

mergify bot commented Jul 26, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.06%. Comparing base (4ee6c69) to head (23f56a8).
Report is 88 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35020      +/-   ##
==========================================
- Coverage   80.98%   80.06%   -0.93%     
==========================================
  Files        1190     1190              
  Lines      143288   143311      +23     
==========================================
- Hits       116048   114745    -1303     
- Misses      22817    24134    +1317     
- Partials     4423     4432       +9     
Files Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v1.go 91.35% <ø> (ø)
internal/distributed/proxy/httpserver/utils.go 87.89% <ø> (ø)

... and 101 files with indirect coverage changes

@congqixia
Copy link
Contributor

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 28, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 28, 2024
/cc @czs007 @congqixia 
master pr: #35020

Signed-off-by: haorenfsa <haorenfsa@gmail.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Aug 2, 2024
@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Aug 5, 2024
@sre-ci-robot sre-ci-robot merged commit 1db0999 into milvus-io:master Aug 5, 2024
11 of 12 checks passed
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
/cc @czs007 @congqixia
/kind enhancement

Signed-off-by: haorenfsa <haorenfsa@gmail.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 15, 2024
Related to milvus-io#35020

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Nov 18, 2024
Related to #35020

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants