-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Gin & restfulv1 handler use sonic json #35020
Conversation
@haorenfsa E2e jenkins job failed, comment |
Signed-off-by: haorenfsa <haorenfsa@gmail.com>
@haorenfsa E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35020 +/- ##
==========================================
- Coverage 80.98% 80.06% -0.93%
==========================================
Files 1190 1190
Lines 143288 143311 +23
==========================================
- Hits 116048 114745 -1303
- Misses 22817 24134 +1317
- Partials 4423 4432 +9
|
/run-cpu-e2e |
/cc @czs007 @congqixia master pr: #35020 Signed-off-by: haorenfsa <haorenfsa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, haorenfsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @czs007 @congqixia /kind enhancement Signed-off-by: haorenfsa <haorenfsa@gmail.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Related to milvus-io#35020 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to #35020 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
/cc @czs007 @congqixia
/kind enhancement