Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Gin & restfulv1 handler use sonic json #35018

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

haorenfsa
Copy link
Contributor

@haorenfsa haorenfsa commented Jul 26, 2024

/cc @czs007 @congqixia
master pr: #35020

@haorenfsa
Copy link
Contributor Author

/kind enhancement

@sre-ci-robot sre-ci-robot added kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines. labels Jul 26, 2024
Copy link
Contributor

mergify bot commented Jul 26, 2024

@haorenfsa Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Jul 26, 2024

@haorenfsa

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@haorenfsa haorenfsa changed the title Gin & restfulv1 handler use sonic json enhance: Gin & restfulv1 handler use sonic json Jul 26, 2024
Copy link
Contributor

mergify bot commented Jul 26, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: haorenfsa <haorenfsa@gmail.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jul 26, 2024
Copy link
Contributor

mergify bot commented Jul 26, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (b3bc7f3) to head (74a3333).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35018      +/-   ##
==========================================
- Coverage   84.85%   81.12%   -3.73%     
==========================================
  Files         786     1051     +265     
  Lines      113237   136666   +23429     
==========================================
+ Hits        96085   110875   +14790     
- Misses      12957    21593    +8636     
- Partials     4195     4198       +3     
Files Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v1.go 91.35% <ø> (ø)
internal/distributed/proxy/httpserver/utils.go 87.89% <ø> (ø)

... and 299 files with indirect coverage changes

@congqixia
Copy link
Contributor

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 28, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0417463 into milvus-io:2.4 Jul 28, 2024
11 of 12 checks passed
@haorenfsa haorenfsa deleted the 2.4 branch July 29, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants