-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Gin & restfulv1 handler use sonic json #35018
Conversation
/kind enhancement |
@haorenfsa Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@haorenfsa E2e jenkins job failed, comment |
Signed-off-by: haorenfsa <haorenfsa@gmail.com>
@haorenfsa E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #35018 +/- ##
==========================================
- Coverage 84.85% 81.12% -3.73%
==========================================
Files 786 1051 +265
Lines 113237 136666 +23429
==========================================
+ Hits 96085 110875 +14790
- Misses 12957 21593 +8636
- Partials 4195 4198 +3
|
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, haorenfsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @czs007 @congqixia
master pr: #35020