Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] fix collection is compacting logic #34862

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

wayblink
Copy link
Contributor

related: #34861 #34792
pr: #34855

@wayblink wayblink added this to the 2.4.7 milestone Jul 21, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 21, 2024
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Copy link
Contributor

mergify bot commented Jul 21, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (c0c3c5f) to head (c317f7f).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34862      +/-   ##
==========================================
+ Coverage   78.15%   78.16%   +0.01%     
==========================================
  Files        1051     1051              
  Lines      136402   136393       -9     
==========================================
+ Hits       106606   106615       +9     
+ Misses      25416    25380      -36     
- Partials     4380     4398      +18     
Files Coverage Δ
internal/datacoord/compaction_trigger_v2.go 72.57% <100.00%> (-0.16%) ⬇️
internal/datacoord/compaction_policy_clustering.go 53.37% <78.57%> (+16.27%) ⬆️

... and 41 files with indirect coverage changes

@wayblink
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 21, 2024
@czs007
Copy link
Collaborator

czs007 commented Jul 22, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9b3bd65 into milvus-io:2.4 Jul 22, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants