Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix collection is compacting logic #34855

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Jul 20, 2024

fix: #34861
also related to: #34792

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Jul 20, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 20, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jul 20, 2024
Copy link
Contributor

mergify bot commented Jul 20, 2024

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (d294fdd) to head (575a9cb).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34855      +/-   ##
==========================================
+ Coverage   80.84%   80.86%   +0.02%     
==========================================
  Files        1175     1175              
  Lines      142066   142057       -9     
==========================================
+ Hits       114849   114875      +26     
+ Misses      22826    22784      -42     
- Partials     4391     4398       +7     
Files Coverage Δ
internal/datacoord/compaction_trigger_v2.go 70.87% <100.00%> (-0.16%) ⬇️
internal/datacoord/compaction_policy_clustering.go 53.37% <78.57%> (+16.27%) ⬆️

... and 31 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Jul 21, 2024
@wayblink wayblink changed the title wip: enhance: add clustering compaction policy ut enhance: add clustering compaction policy ut Jul 21, 2024
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Jul 21, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed ci-passed do-not-merge/invalid-pr-format labels Jul 21, 2024
@wayblink wayblink changed the title enhance: add clustering compaction policy ut fix: fix collection is compacting logic Jul 21, 2024
@mergify mergify bot added the kind/bug Issues or changes related a bug label Jul 21, 2024
@xiaocai2333
Copy link
Contributor

/lgtm

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Jul 22, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Jul 22, 2024
related: #34861 #34792
pr: #34855

---------

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Jul 22, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 52fa668 into milvus-io:master Jul 22, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: clustering compaction collectionIsCompacting logic is wrong
4 participants