Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [cp24]Add ut for l0CompactionTask processExecuting #34801

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #34796
pr: #34800

See also: milvus-io#34796
pr: milvus-io#34800

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 18, 2024
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (0e22650) to head (0c87c7a).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34801      +/-   ##
==========================================
- Coverage   81.15%   78.09%   -3.07%     
==========================================
  Files         786     1050     +264     
  Lines      112871   136268   +23397     
==========================================
+ Hits        91602   106418   +14816     
- Misses      16869    25463    +8594     
+ Partials     4400     4387      -13     
Files Coverage Δ
internal/datacoord/compaction_task_l0.go 82.73% <86.66%> (+14.96%) ⬆️

... and 290 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jul 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ff4bd2c into milvus-io:2.4 Jul 19, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants