Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add ut for l0CompactionTask processExecuting #34800

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #34796

See also: milvus-io#34796

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 18, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jul 18, 2024
See also: milvus-io#34796
pr: milvus-io#34800

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn
Copy link
Contributor Author

rerun ut

sre-ci-robot pushed a commit that referenced this pull request Jul 19, 2024
See also: #34796
pr: #34800

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (40e39ef) to head (db1e3fd).
Report is 45 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34800      +/-   ##
==========================================
+ Coverage   71.80%   80.02%   +8.21%     
==========================================
  Files        1180     1180              
  Lines      142356   142363       +7     
==========================================
+ Hits       102220   113921   +11701     
+ Misses      35737    24051   -11686     
+ Partials     4399     4391       -8     
Files Coverage Δ
internal/datacoord/compaction_task_l0.go 83.00% <86.66%> (+14.71%) ⬆️

... and 245 files with indirect coverage changes

@wayblink
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9a07790 into milvus-io:master Jul 29, 2024
11 of 12 checks passed
@XuanYang-cn XuanYang-cn deleted the add-ut-1 branch July 29, 2024 02:55
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
See also: milvus-io#34796

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants