Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add deltaRowCount in l0 compaction #33997

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Jun 19, 2024

See also: #33998

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 19, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby June 19, 2024 11:02
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 19, 2024
Copy link
Contributor

mergify bot commented Jun 19, 2024

@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@weiliu1031
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 94.52055% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (6a15b6e) to head (48338ed).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33997      +/-   ##
==========================================
+ Coverage   80.92%   81.02%   +0.10%     
==========================================
  Files        1064     1056       -8     
  Lines      136624   136783     +159     
==========================================
+ Hits       110561   110832     +271     
+ Misses      21840    21739     -101     
+ Partials     4223     4212      -11     
Files Coverage Δ
internal/datacoord/compaction_l0_view.go 91.57% <100.00%> (+0.08%) ⬆️
internal/datanode/compaction/l0_compactor.go 92.27% <100.00%> (-0.04%) ⬇️
internal/datacoord/compaction_view.go 63.73% <76.47%> (+0.77%) ⬆️

... and 229 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 19, 2024
@sre-ci-robot sre-ci-robot removed the lgtm label Jun 20, 2024
@mergify mergify bot removed the ci-passed label Jun 20, 2024
Copy link
Contributor

mergify bot commented Jun 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 20, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 04edb07 into milvus-io:master Jun 20, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the f/enhance/l0-logs branch June 20, 2024 09:50
sre-ci-robot pushed a commit that referenced this pull request Jun 20, 2024
See also: #33998 
pr: #33997

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jun 24, 2024
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (milvus-io#32198)
- fix: Fix l0 compactor may cause DN from OOM (milvus-io#33554)
- enhance: Add deltaRowCount in l0 compaction (milvus-io#33997)
- enhance: enable stream writer in compactions (milvus-io#32612)

See also: milvus-io#32451, milvus-io#33547, milvus-io#33998, milvus-io#31679
pr: milvus-io#32198, milvus-io#33554, milvus-io#33997, milvus-io#32612

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jun 25, 2024
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (#32198)
- fix: Fix l0 compactor may cause DN from OOM (#33554)
- enhance: Add deltaRowCount in l0 compaction (#33997)
- enhance: enable stream writer in compactions (#32612)
- fix: turn on compression on stream writers (#34067)
- fix: adding blob memory size in binlog serde (#33324)

See also: #32451, #33547, #33998, #31679
pr: #32198, #33554, #33997, #32612

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Co-authored-by: Ted Xu <ted.xu@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
See also: milvus-io#33998

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants