-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add deltaRowCount in l0 compaction #33997
Conversation
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
/lgtm |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33997 +/- ##
==========================================
+ Coverage 80.92% 81.02% +0.10%
==========================================
Files 1064 1056 -8
Lines 136624 136783 +159
==========================================
+ Hits 110561 110832 +271
+ Misses 21840 21739 -101
+ Partials 4223 4212 -11
|
@XuanYang-cn E2e jenkins job failed, comment |
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR consists of the following commits: - enhance: Tidy compactor and remove dup codes (milvus-io#32198) - fix: Fix l0 compactor may cause DN from OOM (milvus-io#33554) - enhance: Add deltaRowCount in l0 compaction (milvus-io#33997) - enhance: enable stream writer in compactions (milvus-io#32612) See also: milvus-io#32451, milvus-io#33547, milvus-io#33998, milvus-io#31679 pr: milvus-io#32198, milvus-io#33554, milvus-io#33997, milvus-io#32612 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
This PR consists of the following commits: - enhance: Tidy compactor and remove dup codes (#32198) - fix: Fix l0 compactor may cause DN from OOM (#33554) - enhance: Add deltaRowCount in l0 compaction (#33997) - enhance: enable stream writer in compactions (#32612) - fix: turn on compression on stream writers (#34067) - fix: adding blob memory size in binlog serde (#33324) See also: #32451, #33547, #33998, #31679 pr: #32198, #33554, #33997, #32612 --------- Signed-off-by: yangxuan <xuan.yang@zilliz.com> Signed-off-by: Ted Xu <ted.xu@zilliz.com> Co-authored-by: Ted Xu <ted.xu@zilliz.com>
See also: milvus-io#33998 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
See also: #33998