Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: L0 compaction not control parallel count causing DN OOM #33547

Closed
1 task done
XuanYang-cn opened this issue Jun 3, 2024 · 2 comments
Closed
1 task done

[Bug]: L0 compaction not control parallel count causing DN OOM #33547

XuanYang-cn opened this issue Jun 3, 2024 · 2 comments
Assignees
@ThreadDao @XuanYang-cn
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone
2.4.5

Comments

@XuanYang-cn
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

image

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@XuanYang-cn XuanYang-cn added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 3, 2024
@XuanYang-cn XuanYang-cn added this to the 2.4.4 milestone Jun 3, 2024
@XuanYang-cn XuanYang-cn self-assigned this Jun 3, 2024
@ThreadDao
Copy link
Contributor

@XuanYang-cn

compact-opt-master-op-43-5911-milvus-datanode-5d6654857-kj8rc     1/1     Running            4 (57m ago)        3h56m   10.104.13.37    4am-node16   <none>           <none>

@ThreadDao ThreadDao self-assigned this Jun 3, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Jun 3, 2024
@XuanYang-cn
fix: Fix l0 compactor may cause DN from OOM
c1cc4d7 
See also: milvus-io#33547

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this issue Jun 3, 2024
Merged
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Jun 3, 2024
@XuanYang-cn
fix: [2.4] L0 compactor may cause DN OOM
f6eac6d 
See also: milvus-io#33547
pr: milvus-io#33554

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this issue Jun 3, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 5, 2024
@XuanYang-cn
fix: [2.4] L0 compactor may cause DN OOM (#33564)
95582b0 
See also: #33547
pr: #33554

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@yanliang567 yanliang567 modified the milestones: 2.4.4, 2.4.5 Jun 5, 2024
sre-ci-robot pushed a commit that referenced this issue Jun 6, 2024
@XuanYang-cn
fix: Fix l0 compactor may cause DN from OOM (#33554)
4dd0c54 
See also: #33547

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn
Copy link
Contributor Author

should be fixed, althouth DN are still OOM, not caused by L0 compaction
see #33676

XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Jun 24, 2024
@XuanYang-cn
enhance: [cherry-pick] Move compactor into sub package
d5c2dbb 
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (milvus-io#32198)
- fix: Fix l0 compactor may cause DN from OOM (milvus-io#33554)
- enhance: Add deltaRowCount in l0 compaction (milvus-io#33997)
- enhance: enable stream writer in compactions (milvus-io#32612)

See also: milvus-io#32451, milvus-io#33547, milvus-io#33998, milvus-io#31679
pr: milvus-io#32198, milvus-io#33554, milvus-io#33997, milvus-io#32612

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this issue Jun 24, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 25, 2024
@XuanYang-cn @tedxu
enhance: [cherry-pick] Move compactor into sub package (#34098)
a33b686 
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (#32198)
- fix: Fix l0 compactor may cause DN from OOM (#33554)
- enhance: Add deltaRowCount in l0 compaction (#33997)
- enhance: enable stream writer in compactions (#32612)
- fix: turn on compression on stream writers (#34067)
- fix: adding blob memory size in binlog serde (#33324)

See also: #32451, #33547, #33998, #31679
pr: #32198, #33554, #33997, #32612

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Co-authored-by: Ted Xu <ted.xu@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@XuanYang-cn @yellow-shine
fix: Fix l0 compactor may cause DN from OOM (milvus-io#33554)
32111a9 
See also: milvus-io#33547

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThreadDao ThreadDao

@XuanYang-cn XuanYang-cn

Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
2.4.5
Development

No branches or pull requests
3 participants
@ThreadDao @XuanYang-cn @yanliang567