fix: Use pk from binlog during import (#32118) #32194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot
added
size/M
mergify
bot
added
dco-passed
|
@bigsheeper E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #32194 +/- ##
==========================================
- Coverage 81.62% 81.58% -0.04%
==========================================
Files 976 976
Lines 119947 119956 +9
==========================================
- Hits 97904 97866 -38
- Misses 18323 18349 +26
- Partials 3720 3741 +21
|
|
/run-cpu-e2e |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Apr 18, 2024
) During binlog import, even if the primary key's autoID is set to true, the primary key from the binlog should be used instead of being reassigned. issue: milvus-io#31943, milvus-io#28521 pr: milvus-io#32118 Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During binlog import, even if the primary key's autoID is set to true, the primary key from the binlog should be used instead of being reassigned.
issue: #31943, #28521
pr: #32118