-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use pk from binlog during import #32118
fix: Use pk from binlog during import #32118
Conversation
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…4-remove-autoid-for-binlog-import
@bigsheeper ut workflow job failed, comment |
…4-remove-autoid-for-binlog-import
…4-remove-autoid-for-binlog-import
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32118 +/- ##
==========================================
+ Coverage 81.71% 81.76% +0.05%
==========================================
Files 999 999
Lines 123915 123915
==========================================
+ Hits 101252 101323 +71
+ Misses 18775 18726 -49
+ Partials 3888 3866 -22
|
…4-remove-autoid-for-binlog-import
@bigsheeper E2e jenkins job failed, comment |
…4-remove-autoid-for-binlog-import
@bigsheeper E2e jenkins job failed, comment |
/run-cpu-e2e |
@bigsheeper E2e jenkins job failed, comment |
/run-cpu-e2e |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) During binlog import, even if the primary key's autoID is set to true, the primary key from the binlog should be used instead of being reassigned. issue: milvus-io#31943, milvus-io#28521 pr: milvus-io#32118 Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
During binlog import, even if the primary key's autoID is set to true, the primary key from the binlog should be used instead of being reassigned.
issue: #31943, #28521