Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use pk from binlog during import #32118

Merged

Conversation

bigsheeper
Copy link
Contributor

During binlog import, even if the primary key's autoID is set to true, the primary key from the binlog should be used instead of being reassigned.

issue: #31943, #28521

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 10, 2024
Copy link
Contributor

mergify bot commented Apr 10, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Apr 12, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (df2ca7f) to head (2936c05).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32118      +/-   ##
==========================================
+ Coverage   81.71%   81.76%   +0.05%     
==========================================
  Files         999      999              
  Lines      123915   123915              
==========================================
+ Hits       101252   101323      +71     
+ Misses      18775    18726      -49     
+ Partials     3888     3866      -22     
Files Coverage Δ
internal/datanode/importv2/task.go 94.03% <100.00%> (ø)
internal/datanode/importv2/util.go 69.11% <ø> (ø)

... and 31 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Apr 12, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Apr 15, 2024
During binlog import, even if the primary key's autoID is set to true,
the primary key from the binlog should be used instead of being
reassigned.

issue: #31943,
#28521

pr: #32118

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Apr 16, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 16, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 16, 2024
@czs007
Copy link
Collaborator

czs007 commented Apr 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 558feed into milvus-io:master Apr 16, 2024
15 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Apr 18, 2024
)

During binlog import, even if the primary key's autoID is set to true,
the primary key from the binlog should be used instead of being
reassigned.

issue: milvus-io#31943,
milvus-io#28521

pr: milvus-io#32118

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants