Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix querynode panic when binlog ts wrong #25635

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jul 17, 2023

fix issue: #23123
/kind bug

pick 2.2 pr :#23127

Signed-off-by: xige-16 xi.ge@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jul 17, 2023
@sre-ci-robot sre-ci-robot requested review from bigsheeper and sunby July 17, 2023 03:29
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 17, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #25635 (8cb09ab) into master (ad9271c) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25635      +/-   ##
==========================================
- Coverage   82.14%   81.62%   -0.53%     
==========================================
  Files         803      814      +11     
  Lines      106689   109183    +2494     
==========================================
+ Hits        87642    89117    +1475     
- Misses      15969    16978    +1009     
- Partials     3078     3088      +10     
Impacted Files Coverage Δ
internal/core/src/storage/DataCodec.h 100.00% <ø> (ø)
internal/storage/data_codec.go 66.48% <100.00%> (+0.18%) ⬆️

... and 177 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jul 17, 2023
@czs007
Copy link
Collaborator

czs007 commented Jul 18, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 94d6cbb into milvus-io:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants