Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix querynode panic when binlog ts wrong #23127

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Mar 29, 2023

fix issue: #23123
/kind bug

Signed-off-by: xige-16 xi.ge@zilliz.com

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Mar 29, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 29, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #23127 (d4ac34e) into 2.2.0 (38e47ad) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #23127      +/-   ##
==========================================
- Coverage   80.99%   80.98%   -0.02%     
==========================================
  Files         717      717              
  Lines      100529   100533       +4     
==========================================
- Hits        81425    81413      -12     
- Misses      15944    15955      +11     
- Partials     3160     3165       +5     
Impacted Files Coverage Δ
internal/core/src/storage/DataCodec.h 100.00% <ø> (ø)
internal/storage/data_codec.go 66.20% <100.00%> (+0.21%) ⬆️

... and 12 files with indirect coverage changes

@jiaoew1991
Copy link
Contributor

/lgtm

@xige-16
Copy link
Contributor Author

xige-16 commented Mar 30, 2023

rerun ut

2 similar comments
@xige-16
Copy link
Contributor Author

xige-16 commented Mar 30, 2023

rerun ut

@xige-16
Copy link
Contributor Author

xige-16 commented Mar 30, 2023

rerun ut

@mergify mergify bot added the ci-passed label Mar 30, 2023
@czs007
Copy link
Collaborator

czs007 commented Mar 30, 2023

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0d85f02 into milvus-io:2.2.0 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants