Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct scoring of Other typing #1105

Merged
merged 13 commits into from
Jan 29, 2023
Merged

Correct scoring of Other typing #1105

merged 13 commits into from
Jan 29, 2023

Conversation

kristinagalik
Copy link
Contributor

@kristinagalik kristinagalik commented Dec 19, 2022 •
edited
Loading

Closes #627 #925

  • rozdelenie skupiny other do skupin z ktorych sa other skladalo
  • ak je pocet HLAs v skupine 1, tak sa duplikuje (ale ak to neni gene group, tak moze byt skupina prazdna)

kubantjan
kubantjan requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

na kod jsem nekoukal, zatim jen odpoved na dotaz, coz mozna bude znamenat jeste nejakou zmenu :)

@kristinagalik kristinagalik marked this pull request as ready for review January 8, 2023 14:11
@kristinagalik
Copy link
Contributor Author

kristinagalik commented Jan 8, 2023 •
edited
Loading

@kubantjan jedna otazocka - na tie bonusy pre skupiny - ako to mam spravit? lebo takto to dost meni skore medzi ludmi.. mam to dat nejake desatinne? a ak to ma byt ine nez to je trz - od coho sa to ma odvijat? (mam namysli tie bonusy ako EQUAL_BONUS_PER_GROUPS)

@kubantjan
Copy link
Member

@kubantjan jedna otazocka - na tie bonusy pre skupiny - ako to mam spravit? lebo takto to dost meni skore medzi ludmi.. mam to dat nejake desatinne? a ak to ma byt ine nez to je trz - od coho sa to ma odvijat? (mam namysli tie bonusy ako EQUAL_BONUS_PER_GROUPS)

@kristinagalik jako jak ted je bonus pro DR=9 B=3 a A=1? ty pro ty ostatni skupiny zatim 0, nez rekne IKEM jinak.

@kubantjan
Copy link
Member

chceme na to byt ready, aby se to dalo menit protoze jiny zeme to obcas zminuji co je pro ne podstatny, ale zatim se to nereklo a jak jsme na to nebyli ready, tak jsem to ani neresil.

@kristinagalik
Copy link
Contributor Author

done @kubantjan

kubantjan
kubantjan requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nejaky komets

txmatching/utils/enums.py Outdated Show resolved Hide resolved
txmatching/utils/hla_system/hla_transformations/hla_transformations_store.py Outdated Show resolved Hide resolved
txmatching/utils/hla_system/hla_crossmatch.py Outdated Show resolved Hide resolved
txmatching/utils/hla_system/compatibility_index.py Outdated Show resolved Hide resolved
@kristinagalik kristinagalik force-pushed the 627_correct_scoring_of_other_typing branch from 891882e to 886d6d6 Compare January 14, 2023 18:48
kubantjan
kubantjan requested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jeste vylepseni

txmatching/utils/hla_system/hla_transformations/hla_transformations_store.py Outdated Show resolved Hide resolved
txmatching/utils/hla_system/hla_transformations/hla_transformations_store.py Show resolved Hide resolved
@kristinagalik kristinagalik linked an issue Jan 16, 2023 that may be closed by this pull request
refactor how we store "Other" codes #925
Closed
@kristinagalik
Copy link
Contributor Author

kristinagalik commented Jan 16, 2023 •
edited
Loading

kvoli testom (a aj normalnej logike) uz sa nebudu pridavat invalid codes do OTHER_DR ale do INVALID_CODES. Co to ale znamena je ze sa to potom vykresluje aj na FE (kvoli situacii ak je sctrictness type eventu FORGIVING). mam to riesit inak alebo to mozem nechat tak? @kubantjan

plus som to nedavala do HLA_GROUPS_OTHER v tom enum file lebo mi pride ze by to malo byt striktne mimo. je to tak ok?

@kubantjan
Copy link
Member

situacii ak je sctrictness type eventu FORGIVING). mam

Líbí dává smysl :)

@kristinagalik
Copy link
Contributor Author

oki tak je to ready na check :)

kubantjan
kubantjan requested changes Jan 16, 2023
View reviewed changes
txmatching/utils/enums.py Outdated Show resolved Hide resolved
kubantjan
kubantjan requested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jak to vypada na FE kdyz jsou nejaky ty groups prazdny, ukazujou se tam pak nebo ne? Aby to tam nevypadalo hnusne pri ruznych kombinacich (donor DQA ma, recipient ne atp)

kubantjan
kubantjan requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeste tam resim malou upravu tech skupin, vzi email na rodera, ale na zaklade toho jeho mailu udelam jeste novy issue a tohle ted mergneme.

tzn takto asi dobre, jeste poprosim @krllstdn o to aby to prolitl jestli vsemu rozumi a mergujem

kubantjan
kubantjan requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus prijej prosim screenshot jak to ted vypada na FE kdyz se pridaji ty novy skupiny

txmatching/web/frontend/src/app/components/matching-transplant/matching-transplant.component.ts Outdated Show resolved Hide resolved
@kristinagalik
Copy link
Contributor Author

takto to vyzera na fe:
image

image

+ zmazala som tie zmeny z fe, aj tak to nebolo relevant k tejto issue a da sa to vyriesit aj potom

@kubantjan
Copy link
Member

ok, dobre

kubantjan
kubantjan previously approved these changes Jan 25, 2023
View reviewed changes
krllstdn
krllstdn reviewed Jan 25, 2023
View reviewed changes
txmatching/utils/enums.py Outdated Show resolved Hide resolved
txmatching/utils/enums.py Show resolved Hide resolved
@kristinagalik kristinagalik merged commit d98eb37 into master Jan 29, 2023
@kristinagalik kristinagalik deleted the 627_correct_scoring_of_other_typing branch January 29, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubantjan kubantjan kubantjan approved these changes

@krllstdn krllstdn Awaiting requested review from krllstdn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor how we store "Other" codes Correct scoring of Other typing
3 participants
@kristinagalik @kubantjan @krllstdn