Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor how we store "Other" codes #925

Closed
kristinagalik opened this issue Jul 18, 2022 · 1 comment · Fixed by #1105
Closed

refactor how we store "Other" codes #925

kristinagalik opened this issue Jul 18, 2022 · 1 comment · Fixed by #1105
Assignees
@kristinagalik
Labels
backend Backend related task/PR

Comments

@kristinagalik
Copy link
Contributor

kristinagalik commented Jul 18, 2022 •
edited
Loading

there is an inconsistency that for a patient X, for instance DQA1*01:34 is stored in "Other", even though in its group field it has specified that it is DQA. unify this logic and store these codes in different groups rather than note the group in the attributes of a hla code

@kubantjan please check if you agree with my description
@kristinagalik kristinagalik added the backend Backend related task/PR label Jul 18, 2022
@kubantjan
Copy link
Member

yes agreed. @kristinagalik

@kristinagalik kristinagalik mentioned this issue Jan 16, 2023
Merged
@kristinagalik kristinagalik self-assigned this Jan 16, 2023
@kristinagalik kristinagalik linked a pull request Jan 16, 2023 that will close this issue
Correct scoring of Other typing #1105
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristinagalik kristinagalik

Labels
backend Backend related task/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct scoring of Other typing mild-blue/txmatching
2 participants
@kubantjan @kristinagalik