Conversation
* add some context around python imports, builtins v. standard library,
external packages, add links to pvlib, pandas, mpl
* link to pvlib docs, explain returns, return tmy3 metadata and display
* explain what pathlib is, use Markdown backticks to markup code
* link to TMY3 manual, explain units for irradiance, temp, and windspeed
* link to TMY2/TMY3 archives, NSRDB, NREL developer API, and explain
what an API is, link to wikipedia
* link to Energy Plus Weather data, remove bit about unreliability, is
it necessary? Would be true for all data. Link to pvlib.iotools for
reading EPW files
* fix #14 - pvgis is FREE data, add link, and link to pvlig iotools for
getting pvgis TMY data
* link to ABQ coordinates on google maps, use `df_abq` instead of
df_alb, which looks a lot like albedo?
Owner
Author
|
@shirubana and @kanderso-nrel okay if I merge this? |
kandersolar
approved these changes
May 12, 2021
Collaborator
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
LGTM thanks @mikofski!
- don't use apostrophe in TMYs - list NREL SAM Weather Data webpage as perhasp another useful link - fix broken link to pvlib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding to feedback from @abhisheksparikh about tutorial 1, some @jdnewmil already fixed in #13 , some typos and some clarifying comments. Both Abhi and Jeff requested more explicit Python instruction.
tut1-diff.zip