Skip to content

Comments

Jnewm edits#13

Merged
mikofski merged 4 commits intomikofski:mainfrom
jdnewmil:jnewm-edits
May 3, 2021
Merged

Jnewm edits#13
mikofski merged 4 commits intomikofski:mainfrom
jdnewmil:jnewm-edits

Conversation

@jdnewmil
Copy link

@jdnewmil jdnewmil commented May 2, 2021

Mostly spelling, added a comment about not addressing diffuse shading

Copy link
Owner

@mikofski mikofski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdnewmil thanks so much for these edits, especially adding the part about masking of diffuse light by adjacent rows, good to estimate for the reader the scale of the impact from neglecting it.

@mikofski mikofski merged commit 180b37d into mikofski:main May 3, 2021
@jdnewmil jdnewmil deleted the jnewm-edits branch May 3, 2021 17:41
@mikofski mikofski mentioned this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants