Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReleaseNotes: 7S2P.Effie version 3.5.3 #141254

Conversation

SpecterShell
Copy link
Contributor

@SpecterShell SpecterShell commented Feb 28, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 28, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Feb 28, 2024

Hi @SpecterShell,

This manifest removes Apps and Features entries that are present in previous PR versions. These entries should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.

(Automated response - build 841.)

Edit: This check isn't supposed to fire if there are fewer than 2 files. I'll need to review it.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 28, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Feb 28, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Feb 28, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Feb 28, 2024
@SpecterShell
Copy link
Contributor Author

Hi @SpecterShell,

This manifest removes Apps and Features entries that are present in previous PR versions. These entries should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.

(Automated response - build 841.)

Something goes wrong with the bot. 🤔

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 28, 2024
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 28, 2024
@Trenly
Copy link
Contributor

Trenly commented Feb 28, 2024

[Policy] Reset Feedback

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 28, 2024
@Trenly
Copy link
Contributor

Trenly commented Feb 28, 2024

[Policy] Approved

@microsoft-github-policy-service microsoft-github-policy-service bot added Moderator-Approved One of the Moderators has reviewed and approved this PR and removed Needs-Author-Feedback This needs a response from the author. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Feb 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 85554d3 into microsoft:master Feb 28, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants