Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't have Wingetbot retry Validation-Completed when blocking label is present #141376

Open
Trenly opened this issue Feb 28, 2024 · 0 comments
Open
Labels
Area-Bots These issues are related to the bots assisting with automation Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Milestone

Comments

@Trenly
Copy link
Contributor

Trenly commented Feb 28, 2024

Description of the new feature/enhancement

When the Needs-Attention, Changes-Requested, Blocking-Issue, or Needs-Author-Feedback label is present on a PR, the policy service will not approve the PR even if the pipeline has completed successfully.

There is logic in Wingetbot to re-add the Validation-Completed label to ensure that any PRs which can be approved don't get into a stuck state due to a webhook outage or an API rate limit. However, as seen in #141254 it will attempt to re-add the label even when there are conditions which would prevent the Policy Service from being able to approve. This eats up API requests to remove and re-add the label, and can be confusing to users who don't understand why the label is being constantly re-applied.

Therefore, if any of the blocking labels are present on the PR, wingetbot should not remove and re-add the Validation-Completed label

Proposed technical implementation details (optional)

No response

@Trenly Trenly added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage This work item needs to be triaged by a member of the core team. Area-Bots These issues are related to the bots assisting with automation and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Feb 28, 2024
@denelon denelon added this to the 1.8 Packages milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Bots These issues are related to the bots assisting with automation Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

No branches or pull requests

2 participants